fix(leak): don't mutate logger, just make events from it #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 94.24% 93.84% -0.40%
==========================================
Files 2 2
Lines 139 130 -9
==========================================
- Hits 131 122 -9
Misses 5 5
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi |
|
I have no control over that, it requires a maintainer to review & merge it |
|
I will take it. |
|
@mgabeler-lee-6rs Could you help to fix the conflicts? |
|
@appleboy done! |
|
Please merge, it is really annoying |
|
@appleboy please merge this soon. This is a huge issue considering the version was bumped to 1.0.0 recently. |
appleboy
approved these changes
Mar 1, 2024
appleboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #68, #78
The bug also appears without using the customized logger, but it only manifests as a memory leak because the
ConsoleWriterobscures the duplicate data in the logger context.When using a custom logger, reproducing the issue requires concurrent requests ... which is a pretty common thing in real apps :)